Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handled nested evaluation value #376

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

PrajwalBanakar26
Copy link
Contributor

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@uklimaschewski
Copy link
Collaborator

Good idea, thank you. But there are two problems wit this PR:

  • Missing unit test for the new conversion.
  • Code formatting is wrong. You can auto-correct the formatting by running mvn spotless:apply.

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PrajwalBanakar26
Copy link
Contributor Author

PrajwalBanakar26 commented May 29, 2023

Created unit test case for the new conversion.
Implemented the correct code formatting using mvn spotless:apply.

@uklimaschewski
Copy link
Collaborator

Hi, thank you for the PR, very much appreciated. I will merge it into the upcoming 3.1.0 release. This might take a while, because I am very busy at the moment. Before 3.1.0. Plan is to release 3.0.5 first (Bugfix for #374), then do some more work on 3.1.0 and then release it.

@uklimaschewski uklimaschewski merged commit 574efc2 into ezylang:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants