Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'total sales monthly' reporting feature for treasurer #235

Open
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

falkecarlsen
Copy link
Member

@falkecarlsen falkecarlsen commented Feb 28, 2021

During this years VAT bookkeeping it was found that there was no easy way for non-FIT members to look up total sales for any given month. This PR adds that statistic for each of the past 12 months.

The feature could be extended to allow users to pick any month they like but I chose not to implement that since dealing with time sucks. For the purposes of the treasurer this is more than sufficient for monthly bookkeeping and the yearly bookkeeping associated with paying VAT.

Generates a table viewable only by staff-members:
image

@codecov-io
Copy link

codecov-io commented Feb 28, 2021

Codecov Report

Merging #235 (3a76453) into next (7680c65) will decrease coverage by 0.49%.
The diff coverage is 17.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #235      +/-   ##
==========================================
- Coverage   82.42%   81.92%   -0.50%     
==========================================
  Files          30       30              
  Lines        2247     2263      +16     
  Branches      157      160       +3     
==========================================
+ Hits         1852     1854       +2     
- Misses        370      384      +14     
  Partials       25       25              
Impacted Files Coverage Δ
stregsystem/urls.py 75.00% <ø> (ø)
stregsystem/utils.py 66.66% <11.11%> (-5.96%) ⬇️
stregsystem/views.py 59.63% <25.00%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7680c65...3a76453. Read the comment docs.

Copy link
Contributor

@asger-weirsoee asger-weirsoee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux Great Time Month

Copy link
Contributor

@joandrsn joandrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor import change. But other than that, looks good!

stregsystem/views.py Outdated Show resolved Hide resolved
stregsystem/views.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants