Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#13] 속성 패널, 레이어 패널 기능구현 #14

Merged
merged 8 commits into from
Feb 6, 2025

Conversation

lionleeee
Copy link
Collaborator

TODO

  • 속성 패널 기능 구현
  • �도형 생성 시 레이어 추가

@lionleeee lionleeee requested a review from f-lab-guell February 5, 2025 12:28
@lionleeee lionleeee self-assigned this Feb 5, 2025
@@ -12,7 +11,7 @@ export const TOOLS = [
{ id: "rectangle", icon: BsSquare, title: "사각형" },
{ id: "circle", icon: BsCircle, title: "원형" },
{ id: "polygon", icon: BsTriangle, title: "다각형" },
{ id: "text", icon: BsTextareaT, title: "텍스트" },
//{ id: "text", icon: BsTextareaT, title: "텍스트" },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

삭제 안하신 이유가 있나요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 텍스트 기능을 구현 못해서 일단 지워놨습니다.
동작하지 않는데 메뉴에 있으면 안된다고 생각했습니다.


export const RectangleProperties = () => {
const { toolSettings, updateToolSettings } = useEditorStore();
const settings = toolSettings.rectangle;
return (
<div className="space-y-4">
<NumberInput
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인풋들 컴포넌트화 잘해두셔서 재사용성이 아주 좋네요~~!

[#15] 설정 내보내기, 불러오기
@lionleeee lionleeee merged commit fbce772 into main Feb 6, 2025
1 check passed
@lionleeee lionleeee deleted the feat/properties branch February 6, 2025 09:04
Copy link

sonarqubecloud bot commented Feb 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
12.9% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants