주문하기 API 구현 #26
Open
주문하기 API 구현 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-sean
reviewed
Oct 29, 2022
|
|
||
| Long savedOrderId = orderCommonService.save(order.toOrderDto()); | ||
| orderMenuCommonService.saveAll(savedOrderId, order.toOrderMenuDtos()); | ||
| return null; |
There was a problem hiding this comment.
반환값이 없네요~ order 를 넘겨줘야 할 듯
f-lab-sean
reviewed
Oct 29, 2022
|
|
||
| orderService.order(request, requestUser); | ||
|
|
||
| return ResponseEntity.ok(SuccessResult.createResult()); |
There was a problem hiding this comment.
주문과 결제를 분리하려면 주문번호를 응답을 주어야, 결제를 진행 가능하겠죠?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내용
/api/orders)View Request(
OrderDoViewRequest.java) 객체와 비즈니스 모델(OrderMenu.java)을 나누었지만 OrderService 내에서 이를 매핑하는 과정이 조금 복잡하게 만든 것 같아 추가 리팩토링이 필요할 것 같습니다! 변경파일 양이 많아 먼저 PR 올립니다~!