Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#39] 동영상 업로드 책임 분리하기 #42

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[#39] 동영상 업로드 책임 분리하기 #42

wants to merge 3 commits into from

Conversation

SeongjinDaniel
Copy link
Collaborator

@SeongjinDaniel SeongjinDaniel commented Dec 16, 2020 •
edited
Loading

@SeongjinDaniel
clean push
c297ef1
@SeongjinDaniel
clean push
02ef35f
@SeongjinDaniel
[#39] Modify videoservice
a13e5c4 
Split video file and video infomation upload method
@SeongjinDaniel SeongjinDaniel self-assigned this Dec 16, 2020
f-lab-dev
f-lab-dev reviewed Dec 17, 2020
View reviewed changes
src/main/java/me/dev/oliver/mytube/controller/VideoController.java

/**
* 동영상에 필요한 정보들을 업로드.
* 주의) uploadVideo 메서드와 같이 사용해야함.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거는 주석으로 단다고 무조건 개발자들이 그대로 따라할까요? 제대로 보지 못하고 개발하는 상황도 발생할 수 있습니다. 순서를 보장하기 위한 것들을 코드로 작성해야합니다~

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-dev f-lab-dev f-lab-dev left review comments

Assignees

@SeongjinDaniel SeongjinDaniel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeongjinDaniel @f-lab-dev