Purs 0.15 #136
Merged
Purs 0.15 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… node's internal FS stuff since ps-node-fs doesn't anymore
martyall
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one might be a bit messy -- though was fairly straightforward.
purescript-node-fsno longer has FS.Internal to allow accessing thenode:fsmodule directly, so I had to manually recreate it in FFI forChanterelle.Internal.Utils.FS.mkdirpFFI inChanterelle.Internal.Utils.FS, since we have a perfectly good package for that.I'm a little scared of this one, I think it needs a thorough test with a project -- which I'm going to hold off on until eth-core/web3/solc are merged in -- reason being I changed how FS stuff gets invoked and I'd like to go through a "workflow" prior to saying this is good to go.