Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup on aisle chanterelle #139

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Cleanup on aisle chanterelle #139

merged 3 commits into from
Sep 20, 2023

Conversation

martyall
Copy link
Contributor

@martyall martyall commented Sep 20, 2023

No functional difference in this PR, only code transformation, module reorg, and inlining. Ultimate goals:

  • remove named class instances (this is straightforward)
  • get rid of utility functions that we don't use anywhere hence actually have no utility
  • get rid of unnecessary split between Internal and not. There are really no Internal modules here anyway, everything makes explicit assumptions about the project structure, file structure, hierarchy, etc. It makes more sense to just expose the Test module and some kind of DeployScript rexports to facilitate writing deployments and isolating some code as "this is all you will need as a library writer"
  • inline almost all of Utils.Errors : These combinators do not pass whatever threshold that is, with perhaps the exception of withExceptT'. It's more of an indication that the code is structured poorly that there don't exist any anlogues of these functions in other purescript libs, even Control.Error.Utils.

Copy link
Member

@iostat iostat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright edgar, now drop a train on em

@martyall martyall merged commit 0cc1dd4 into master Sep 20, 2023
2 checks passed
@martyall martyall deleted the cleanup-chanterelle branch September 20, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants