Removing table-hover from tables to address inconsistency in hover color

Fixes openshift#1904 Until patternfly/patternfly-design#314 is addressed, I think we should avoid using .table-hover in our tables.
f0x11 · Mar 26, 2018 · 3a84766 · 3a84766
1 parent ee3787c
commit 3a84766
Show file tree

Hide file tree

Showing 16 changed files with 57 additions and 33 deletions.
diff --git a/app/views/browse/build-config.html b/app/views/browse/build-config.html
@@ -178,7 +178,7 @@ <h2 translate>No builds.</h2>
                     </div>
                   </div>
                 </div>
-                <table ng-if="!(buildConfig | isJenkinsPipelineStrategy)" class="table table-bordered table-hover table-mobile">
+                <table ng-if="!(buildConfig | isJenkinsPipelineStrategy)" class="table table-bordered table-mobile">
                   <thead>
                     <tr>
                       <th translate>Build</th>
@@ -220,7 +220,7 @@ <h2 translate>No builds.</h2>
                 </table>
                 <div ng-if="buildConfig | isJenkinsPipelineStrategy">
                   <build-pipeline build="build" ng-repeat="build in orderedBuilds track by (build | uid)"></build-pipeline>
-                  <table ng-if="(builds | hashSize) === 0" class="table table-bordered table-hover table-mobile">
+                  <table ng-if="(builds | hashSize) === 0" class="table table-bordered table-mobile">
                     <tbody><tr><td><em>{{emptyMessage}}</em></td></tr></tbody>
                   </table>
                 </div>

diff --git a/app/views/browse/config-maps.html b/app/views/browse/config-maps.html
@@ -28,7 +28,7 @@ <h1 translate>
         <div class="col-md-12">
           <div ng-if="!loaded" translate>Loading...</div>
           <div ng-if="loaded">
-            <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+            <table class="table table-bordered table-mobile table-layout-fixed">
               <colgroup>
                 <col class="col-sm-5">
               </colgroup>

diff --git a/app/views/browse/deployment-config.html b/app/views/browse/deployment-config.html
@@ -129,7 +129,7 @@ <h1 class="contains-actions">
                   </div>
                 </div>
               </div>
-              <table class="table table-bordered table-hover table-mobile">
+              <table class="table table-bordered table-mobile">
                 <thead>
                   <tr>
                     <th translate>Deployment</th>

diff --git a/app/views/browse/deployment.html b/app/views/browse/deployment.html
@@ -89,7 +89,7 @@ <h1 class="contains-actions">
                   </div>
                 </div>
               </div>
-              <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+              <table class="table table-bordered table-mobile table-layout-fixed">
                 <colgroup>
                   <col class="col-sm-2">
                   <col class="col-sm-4">

diff --git a/app/views/browse/routes.html b/app/views/browse/routes.html
@@ -26,7 +26,7 @@ <h1 translate>
       <alerts alerts="alerts"></alerts>
       <div class="row">
         <div class="col-md-12">
-          <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+          <table class="table table-bordered table-mobile table-layout-fixed">
             <colgroup>
               <col class="col-sm-3">
               <col class="col-sm-3">

diff --git a/app/views/browse/stateful-sets.html b/app/views/browse/stateful-sets.html
@@ -28,7 +28,7 @@ <h1 translate>
       <div ng-if="!loaded" translate>Loading...</div>
       <div class="row" ng-if="loaded">
         <div class="col-md-12">
-          <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+          <table class="table table-bordered table-mobile table-layout-fixed">
             <colgroup>
               <col class="col-sm-5">
             </colgroup>

diff --git a/app/views/builds.html b/app/views/builds.html
@@ -23,7 +23,7 @@ <h1 translate>
       <alerts alerts="alerts"></alerts>
       <div class="row">
         <div class="col-md-12">
-          <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+          <table class="table table-bordered table-mobile table-layout-fixed">
             <colgroup>
               <col class="col-sm-2">
               <col class="col-sm-1">

diff --git a/app/views/deployments.html b/app/views/deployments.html
@@ -24,7 +24,7 @@ <h1 translate>
       <div class="row">
         <div class="col-md-12">
           <h3 ng-if="(deployments | size) || (replicaSets | size)" translate>Deployment Configurations</h3>
-          <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+          <table class="table table-bordered table-mobile table-layout-fixed">
             <colgroup>
               <col class="col-sm-3">
               <col class="col-sm-2">
@@ -110,7 +110,7 @@ <h3 ng-if="(deployments | size) || (replicaSets | size)" translate>Deployment Co
           </table>
           <div ng-if="deployments | size">
             <h3 translate>Deployments</h3>
-            <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+            <table class="table table-bordered table-mobile table-layout-fixed">
               <colgroup>
                 <col class="col-sm-4">
                 <col class="col-sm-2">
@@ -155,7 +155,7 @@ <h3 translate>Deployments</h3>
           </div>
           <div ng-if="replicaSets | hashSize" id="replica-sets">
             <h3 translate>Replica Sets</h3>
-            <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+            <table class="table table-bordered table-mobile table-layout-fixed">
               <colgroup>
                 <col class="col-sm-4">
               </colgroup>
@@ -183,7 +183,7 @@ <h3 translate>Replica Sets</h3>
           </div>
           <div ng-if="(unfilteredReplicationControllers | hashSize) > 0" id="replica-controllers">
             <h3 translate>Other Replication Controllers</h3>
-            <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+            <table class="table table-bordered table-mobile table-layout-fixed">
               <colgroup>
                 <col class="col-sm-5">
               </colgroup>

diff --git a/app/views/directives/events.html b/app/views/directives/events.html
@@ -34,7 +34,7 @@
       </div>
     </div>
   </div>
-  <table class="table table-bordered table-condensed table-mobile table-hover table-layout-fixed events-table">
+  <table class="table table-bordered table-condensed table-layout-fixed events-table">
     <thead>
       <tr>
         <th id="time" translate>Time</th>

diff --git a/app/views/directives/pods-table.html b/app/views/directives/pods-table.html
@@ -1,4 +1,4 @@
-<table class="table table-bordered table-hover table-mobile table-layout-fixed">
+<table class="table table-bordered table-mobile table-layout-fixed">
   <colgroup>
     <col class="col-sm-4">
     <col class="col-sm-3">

diff --git a/app/views/directives/traffic-table.html b/app/views/directives/traffic-table.html
@@ -1,5 +1,5 @@
 <!-- Table combining routes and ports for a service -->
-<table class="table table-bordered table-hover table-mobile">
+<table class="table table-bordered table-mobile">
   <thead>
     <tr>
       <th>{{(customNameHeader || 'Route') | translate}}<span ng-if="showNodePorts" translate> / Node Port</span></th>

diff --git a/app/views/images.html b/app/views/images.html
@@ -23,7 +23,7 @@ <h1 translate>
       <alerts alerts="alerts"></alerts>
       <div class="row">
         <div class="col-md-12">
-          <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+          <table class="table table-bordered table-mobile table-layout-fixed">
             <colgroup>
               <col class="col-sm-3">
               <col class="col-sm-5">

diff --git a/app/views/secrets.html b/app/views/secrets.html
@@ -22,7 +22,7 @@ <h1 translate>
       <div ng-if="!loaded" class="mar-top-xl" translate>Loading...</div>
       <div ng-if="loaded" class="row">
         <div class="col-md-12">
-          <table class="table table-bordered table-hover table-mobile secrets-table table-layout-fixed">
+          <table class="table table-bordered table-mobile secrets-table table-layout-fixed">
             <colgroup>
               <col class="col-sm-5">
               <col class="col-sm-5">

diff --git a/app/views/services.html b/app/views/services.html
@@ -23,7 +23,7 @@ <h1 translate>
       <alerts alerts="alerts"></alerts>
       <div class="row">
         <div class="col-md-12">
-          <table class="table table-bordered table-hover table-mobile table-layout-fixed">
+          <table class="table table-bordered table-mobile table-layout-fixed">
             <colgroup>
               <col class="col-sm-3">
             </colgroup>

diff --git a/app/views/storage.html b/app/views/storage.html
@@ -34,7 +34,7 @@ <h2 translate>Persistent Volume Claims</h2>
               <a ng-if="outOfClaims" href="" class="btn btn-default disabled" aria-disabled="true" translate>Create Storage</a>
             </div>
           </div>
-          <table class="table table-bordered table-hover table-mobile table-layout-fixed" ng-class="{ 'table-empty': (pvcs | hashSize) === 0 }">
+          <table class="table table-bordered table-mobile table-layout-fixed" ng-class="{ 'table-empty': (pvcs | hashSize) === 0 }">
             <colgroup>
               <col class="col-sm-5">
             </colgroup>

diff --git a/dist/scripts/templates.js b/dist/scripts/templates.js
@@ -1851,7 +1851,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</div>\n" +
     "</div>\n" +
     "</div>\n" +
-    "<table ng-if=\"!(buildConfig | isJenkinsPipelineStrategy)\" class=\"table table-bordered table-hover table-mobile\">\n" +
+    "<table ng-if=\"!(buildConfig | isJenkinsPipelineStrategy)\" class=\"table table-bordered table-mobile\">\n" +
     "<thead>\n" +
     "<tr>\n" +
     "<th translate>Build</th>\n" +
@@ -1893,8 +1893,13 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</table>\n" +
     "<div ng-if=\"buildConfig | isJenkinsPipelineStrategy\">\n" +
     "<build-pipeline build=\"build\" ng-repeat=\"build in orderedBuilds track by (build | uid)\"></build-pipeline>\n" +
+<<<<<<< 96de671426db59fb68bd3b8af93d73f5d6503d3e
     "<table ng-if=\"(builds | hashSize) === 0\" class=\"table table-bordered table-hover table-mobile\">\n" +
     "<tbody><tr><td><em>{{emptyMessage|translate}}</em></td></tr></tbody>\n" +
+=======
+    "<table ng-if=\"(builds | hashSize) === 0\" class=\"table table-bordered table-mobile\">\n" +
+    "<tbody><tr><td><em>{{emptyMessage}}</em></td></tr></tbody>\n" +
+>>>>>>> Removing table-hover from tables to address inconsistency in hover color
     "</table>\n" +
     "</div>\n" +
     "</div>\n" +
@@ -2334,7 +2339,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<div class=\"col-md-12\">\n" +
     "<div ng-if=\"!loaded\" translate>Loading...</div>\n" +
     "<div ng-if=\"loaded\">\n" +
-    "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-5\">\n" +
     "</colgroup>\n" +
@@ -2481,7 +2486,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</div>\n" +
     "</div>\n" +
     "</div>\n" +
-    "<table class=\"table table-bordered table-hover table-mobile\">\n" +
+    "<table class=\"table table-bordered table-mobile\">\n" +
     "<thead>\n" +
     "<tr>\n" +
     "<th translate>Deployment</th>\n" +
@@ -2805,8 +2810,12 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</div>\n" +
     "</div>\n" +
     "</div>\n" +
+<<<<<<< 96de671426db59fb68bd3b8af93d73f5d6503d3e
 >>>>>>> Label Filter for Kubernetes Deployment History Tab
     "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+=======
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
+>>>>>>> Removing table-hover from tables to address inconsistency in hover color
     "<colgroup>\n" +
     "<col class=\"col-sm-2\">\n" +
     "<col class=\"col-sm-4\">\n" +
@@ -3721,7 +3730,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<alerts alerts=\"alerts\"></alerts>\n" +
     "<div class=\"row\">\n" +
     "<div class=\"col-md-12\">\n" +
-    "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-3\">\n" +
     "<col class=\"col-sm-3\">\n" +
@@ -4141,7 +4150,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<div ng-if=\"!loaded\" translate>Loading...</div>\n" +
     "<div class=\"row\" ng-if=\"loaded\">\n" +
     "<div class=\"col-md-12\">\n" +
-    "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-5\">\n" +
     "</colgroup>\n" +
@@ -4206,7 +4215,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<alerts alerts=\"alerts\"></alerts>\n" +
     "<div class=\"row\">\n" +
     "<div class=\"col-md-12\">\n" +
-    "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-2\">\n" +
     "<col class=\"col-sm-1\">\n" +
@@ -5282,8 +5291,13 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<alerts alerts=\"alerts\"></alerts>\n" +
     "<div class=\"row\">\n" +
     "<div class=\"col-md-12\">\n" +
+<<<<<<< 96de671426db59fb68bd3b8af93d73f5d6503d3e
     "<h3 ng-if=\"(deployments | size) || (replicaSets | size)\" translate>Deployment Configurations</h3>\n" +
     "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+=======
+    "<h3 ng-if=\"(deployments | size) || (replicaSets | size)\">Deployment Configurations</h3>\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
+>>>>>>> Removing table-hover from tables to address inconsistency in hover color
     "<colgroup>\n" +
     "<col class=\"col-sm-3\">\n" +
     "<col class=\"col-sm-2\">\n" +
@@ -5368,8 +5382,13 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</tbody>\n" +
     "</table>\n" +
     "<div ng-if=\"deployments | size\">\n" +
+<<<<<<< 96de671426db59fb68bd3b8af93d73f5d6503d3e
     "<h3 translate>Deployments</h3>\n" +
     "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+=======
+    "<h3>Deployments</h3>\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
+>>>>>>> Removing table-hover from tables to address inconsistency in hover color
     "<colgroup>\n" +
     "<col class=\"col-sm-4\">\n" +
     "<col class=\"col-sm-2\">\n" +
@@ -5414,7 +5433,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</div>\n" +
     "<div ng-if=\"replicaSets | hashSize\" id=\"replica-sets\">\n" +
     "<h3>Replica Sets</h3>\n" +
-    "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-4\">\n" +
     "</colgroup>\n" +
@@ -5441,8 +5460,13 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</table>\n" +
     "</div>\n" +
     "<div ng-if=\"(unfilteredReplicationControllers | hashSize) > 0\" id=\"replica-controllers\">\n" +
+<<<<<<< 96de671426db59fb68bd3b8af93d73f5d6503d3e
     "<h3 translate>Other Replication Controllers</h3>\n" +
     "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+=======
+    "<h3>Other Replication Controllers</h3>\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
+>>>>>>> Removing table-hover from tables to address inconsistency in hover color
     "<colgroup>\n" +
     "<col class=\"col-sm-5\">\n" +
     "</colgroup>\n" +
@@ -7042,7 +7066,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</div>\n" +
     "</div>\n" +
     "</div>\n" +
-    "<table class=\"table table-bordered table-condensed table-mobile table-hover table-layout-fixed events-table\">\n" +
+    "<table class=\"table table-bordered table-condensed table-layout-fixed events-table\">\n" +
     "<thead>\n" +
     "<tr>\n" +
     "<th id=\"time\" translate>Time</th>\n" +
@@ -9033,7 +9057,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
 
 
   $templateCache.put('views/directives/pods-table.html',
-    "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-4\">\n" +
     "<col class=\"col-sm-3\">\n" +
@@ -9289,7 +9313,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
 
 
   $templateCache.put('views/directives/traffic-table.html',
-    " <table class=\"table table-bordered table-hover table-mobile\">\n" +
+    " <table class=\"table table-bordered table-mobile\">\n" +
     "<thead>\n" +
     "<tr>\n" +
     "<th>{{(customNameHeader || 'Route') | translate}}<span ng-if=\"showNodePorts\" translate> / Node Port</span></th>\n" +
@@ -10575,7 +10599,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<alerts alerts=\"alerts\"></alerts>\n" +
     "<div class=\"row\">\n" +
     "<div class=\"col-md-12\">\n" +
-    "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-3\">\n" +
     "<col class=\"col-sm-5\">\n" +
@@ -13533,7 +13557,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<div ng-if=\"!loaded\" class=\"mar-top-xl\" translate>Loading...</div>\n" +
     "<div ng-if=\"loaded\" class=\"row\">\n" +
     "<div class=\"col-md-12\">\n" +
-    "<table class=\"table table-bordered table-hover table-mobile secrets-table table-layout-fixed\">\n" +
+    "<table class=\"table table-bordered table-mobile secrets-table table-layout-fixed\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-5\">\n" +
     "<col class=\"col-sm-5\">\n" +
@@ -13598,7 +13622,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<alerts alerts=\"alerts\"></alerts>\n" +
     "<div class=\"row\">\n" +
     "<div class=\"col-md-12\">\n" +
-    "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\">\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-3\">\n" +
     "</colgroup>\n" +
@@ -13741,7 +13765,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<a ng-if=\"outOfClaims\" href=\"\" class=\"btn btn-default disabled\" aria-disabled=\"true\" translate>Create Storage</a>\n" +
     "</div>\n" +
     "</div>\n" +
-    "<table class=\"table table-bordered table-hover table-mobile table-layout-fixed\" ng-class=\"{ 'table-empty': (pvcs | hashSize) === 0 }\">\n" +
+    "<table class=\"table table-bordered table-mobile table-layout-fixed\" ng-class=\"{ 'table-empty': (pvcs | hashSize) === 0 }\">\n" +
     "<colgroup>\n" +
     "<col class=\"col-sm-5\">\n" +
     "</colgroup>\n" +