Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same string replacement for keys in cache getter as setter #369

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

BrewCurious
Copy link
Contributor

This is a bit of a band-aid approach to deal with a specific use case for myself. What should eventually happen is a reevaluation of all is_file, write and read calls in base.php to have the filename strings always get passed through the fixslashes method before checking the filesystem to ensure consistent and filesystem-safe keys.

@BrewCurious
Copy link
Contributor Author

@ikkez Is this something that could be merged? I'm having to manually update my core files anytime I sync with Composer to prevent this error. If there are any other considerations that I'm missing, I could help with the solutions. Thanks.

@ikkez
Copy link
Member

ikkez commented Feb 21, 2024

thanks.. I'll keep this in mind to review all file path handling with fixslashes.. I'll merge this nevertheless for now ;)

@ikkez ikkez merged commit 6646844 into f3-factory:master Feb 21, 2024
@BrewCurious
Copy link
Contributor Author

@ikkez Thanks for the merge. Could you let me know what the typical process/timeline looks like for updates made to master here getting updated via the link in the bcosca/fatfree-core repo? That's the package that I'm connecting to in my project's composer's config right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants