Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect usage of the
FILTER_FLAG_NO_PRIV_RANGE
flag in thefilter_var()
function.The
FILTER_FLAG_NO_PRIV_RANGE
flag is used to EXCLUDE private IP ranges. But in the code, the flag is used with theFILTER_VALIDATE_IP
filter, which actually VALIDATES the IP address. As a result, the method returns the opposite result of what is intended.So we need to change the usage of the
FILTER_FLAG_NO_PRIV_RANGE
flag. Instead of using it with theFILTER_VALIDATE_IP
filter, we should use it with theFILTER_FLAG_NO_PRIV_RANGE
flag DIRECTLY.By using old(bugged) function we have:
Now by using new(fixed) function we have: