Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Alembic importer to reader #1048

Merged
merged 4 commits into from
Oct 21, 2023
Merged

Convert Alembic importer to reader #1048

merged 4 commits into from
Oct 21, 2023

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented Oct 10, 2023

No description provided.

@Meakk Meakk self-assigned this Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #1048 (4a0ef1c) into master (07d6c6e) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1048   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files         120      120           
  Lines        7015     7025   +10     
=======================================
+ Hits         6750     6760   +10     
  Misses        265      265
Files Coverage Δ
plugins/alembic/module/vtkF3DAlembicReader.cxx 100.00% <100.00%> (ø)
plugins/alembic/module/vtkF3DAlembicReader.h 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Meakk Meakk requested a review from mwestphal October 11, 2023 18:13
@mwestphal
Copy link
Contributor

doc update missing

@Meakk
Copy link
Contributor Author

Meakk commented Oct 17, 2023

doc update missing

what doc?

@mwestphal
Copy link
Contributor

doc update missing

what doc?

I was thinking about this:

https://github.com/f3d-app/f3d/blob/master/doc/user/USAGE.md?plain=1#L28

But it was never listed as a full scene format anyway. soo all good.

@Meakk Meakk merged commit 8eddb96 into f3d-app:master Oct 21, 2023
41 checks passed
@Meakk Meakk deleted the alembic-refactor branch October 21, 2023 17:31
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
@Meakk
Convert Alembic importer to reader (#1048)
152c942
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
@Meakk
Convert Alembic importer to reader (f3d-app#1048)
4364643
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyue nyue nyue left review comments

@mwestphal mwestphal mwestphal approved these changes

Assignees

@Meakk Meakk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Meakk @mwestphal @nyue