Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set default window name inside lib #1057

Merged

Conversation

shaikan
Copy link
Contributor

@shaikan shaikan commented Oct 26, 2023

Fix for #1018
Added code to set default title for window inside libf3d.

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #1057 (0a5fb66) into master (5075583) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1057   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files         120      120           
  Lines        7025     7026    +1     
=======================================
+ Hits         6760     6761    +1     
  Misses        265      265           
Files Coverage Δ
library/src/window_impl.cxx 98.63% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Meakk Meakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@mwestphal mwestphal merged commit 6a60ef0 into f3d-app:master Oct 26, 2023
41 checks passed
@mwestphal
Copy link
Contributor

Thanks @shaikan !

@shaikan shaikan deleted the fix-setting-default-window-name-in-libf3d branch October 27, 2023 03:26
@shaikan shaikan restored the fix-setting-default-window-name-in-libf3d branch November 6, 2023 17:39
mwestphal added a commit that referenced this pull request Feb 10, 2024
…-in-libf3d

Fix set default window name inside lib
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
…ow-name-in-libf3d

Fix set default window name inside lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants