Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VTK 9.3 in CI #1068

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Add VTK 9.3 in CI #1068

merged 1 commit into from
Nov 23, 2023

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented Nov 14, 2023

No description provided.

@Meakk Meakk self-assigned this Nov 14, 2023
@mwestphal
Copy link
Contributor

you can drop the two last "check" action from .github/actions/generic-ci/action.yml as they are very expansive with vtk 9.2.6. Testing it only wiht 9.3 is enough.

@mwestphal
Copy link
Contributor

I do not know why raytracing would behave differently on 9.3.0. Investigation needed.

@Meakk
Copy link
Contributor Author

Meakk commented Nov 15, 2023

you can drop the two last "check" action from .github/actions/generic-ci/action.yml as they are very expansive with vtk 9.2.6. Testing it only wiht 9.3 is enough.

What do you mean?

@mwestphal
Copy link
Contributor

in .github/actions/generic-ci/action.yml there is two steps named Check F3D_PLUGINS_PATH using plugin example and Check Install. These steps uses the install which contains the default configuration which contains the default HDRI.

On macOS CI, displaying an HDRI is very slow without the cache (because github provide not a lot of CPU on macOS), which means that these two steps takes 2/3 minutes each, which is why macOS + VTK v9.2.6 is always the last CI to finish.

With older VTK version, these steps are skipped but I decided to keep these steps for 9.2.6 because it is important to check that the install of F3D is working (at least) with the last release of VTK.

With VTK 9.3.0 out, we can drop these two steps with 9.2.6 to increase CI speed.

hth :)

@mwestphal
Copy link
Contributor

Do you want me to take care of this @Meakk ?

@Meakk
Copy link
Contributor Author

Meakk commented Nov 21, 2023

Any idea why raytracing is failing on 9.3?

@mwestphal
Copy link
Contributor

Any idea why raytracing is failing on 9.3

Needs investigation

@Meakk Meakk force-pushed the vtk-9.3 branch 2 times, most recently from b9745e8 to 58ae03f Compare November 23, 2023 07:15
@Meakk Meakk force-pushed the vtk-9.3 branch 2 times, most recently from 869f0a2 to 58b6b08 Compare November 23, 2023 09:47
@Meakk
Copy link
Contributor Author

Meakk commented Nov 23, 2023

@mwestphal looks better now, please take another look

@Meakk Meakk merged commit 8641276 into f3d-app:master Nov 23, 2023
45 checks passed
@Meakk Meakk deleted the vtk-9.3 branch November 23, 2023 15:16
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants