-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segfault on reload with progress bar #778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mwestphal
commented
Apr 26, 2023
- Fix a segfault on reload with progress bar
- Feature is not behaving as expected, on reload, the progress bar DO NOT APPEAR but nothing is visible during the reload
- Add progress bar smoke test
- Fix Reloading a file while using a progress bar causes a segfault #761
mwestphal
force-pushed
the
fix_segfault_progress
branch
from
April 26, 2023 09:34
56b1a00
to
f783971
Compare
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 96.62% 96.69% +0.06%
==========================================
Files 115 115
Lines 5776 5777 +1
==========================================
+ Hits 5581 5586 +5
+ Misses 195 191 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Meakk
reviewed
Apr 26, 2023
mwestphal
force-pushed
the
fix_segfault_progress
branch
from
April 26, 2023 13:15
7658acc
to
eef067d
Compare
mwestphal
force-pushed
the
fix_segfault_progress
branch
from
April 26, 2023 13:49
eef067d
to
8b1b8d0
Compare
Meakk
reviewed
Apr 26, 2023
mwestphal
force-pushed
the
fix_segfault_progress
branch
from
April 26, 2023 16:52
8b1b8d0
to
44253f6
Compare
Meakk
approved these changes
Apr 26, 2023
mwestphal
added a commit
that referenced
this pull request
Feb 10, 2024
Fix segfault on reload with progress bar
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
Fix segfault on reload with progress bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.