Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hdri logic when reloading files #779

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

mwestphal
Copy link
Contributor

  • Fix an 2.0.0 issue when reloading a file with an HDRI
  • Add a test

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #779 (bef025f) into master (8b22935) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files         115      115           
  Lines        5776     5778    +2     
=======================================
+ Hits         5581     5583    +2     
  Misses        195      195           
Impacted Files Coverage Δ
library/VTKExtensions/Rendering/vtkF3DRenderer.cxx 99.65% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mwestphal mwestphal requested a review from Meakk April 26, 2023 14:52
@mwestphal mwestphal merged commit fab37ca into f3d-app:master Apr 26, 2023
mwestphal added a commit that referenced this pull request Feb 10, 2024
Fix hdri logic when reloading files
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
Fix hdri logic when reloading files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants