-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid hardcoded path to conform to current CMake pratice #782
Conversation
Definitely a good idea ! |
strange unrelated CI issues, investigating. |
I've rerun, looks like an intermitent docker repository failure |
Thanks for your quick looking at this. |
I see a few other usages of |
BTW @topazus , I see that you are a fedora packager. Do you plan to add F3D to fedora packages ? :) |
You mean the usage of f3d/application/CMakeLists.txt Lines 46 to 51 in e035ec3
|
No worries, I will take care of it. |
Yes, I would like to make f3d package into Fedora official repository. Maybe I can do this this weekend. |
Perfect, thanks @topazus ! |
It maybe be better to use the
${CMAKE_INSTALL_LIBDIR}
,${CMAKE_INSTALL_INCLUDEDIR}
, instead of hardcoding the directory.${CMAKE_INSTALL_LIBDIR}
,${CMAKE_INSTALL_INCLUDEDIR}
, et al. are defined by theGNUInstallDirs
that represents the platform-specific installation directory and provides install directory variables defined by the GNU Coding Standards.Ref:
https://gitlab.kitware.com/cmake/cmake/-/merge_requests/8111
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
libsdl-org/SDL@6956f4a