Fix positional args help #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #791 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 115 115
Lines 5779 5781 +2
=======================================
+ Hits 5588 5590 +2
Misses 191 191
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
snoyer
reviewed
Apr 29, 2023
snoyer
reviewed
Apr 29, 2023
mwestphal
force-pushed
the
fix_missing_positional_help
branch
from
da3bec8
to
c610272
Compare
snoyer
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
f3d/application/F3DOptionsParser.cxx
Line 271 in c610272
You may want to pluralize "Input files" to match "<files>" while you're here.
Otherwise all good now.
|
Thanks ! |
mwestphal
force-pushed
the
fix_missing_positional_help
branch
from
c610272
to
a49ece2
Compare
Meakk
approved these changes
Apr 29, 2023
mwestphal
added a commit
that referenced
this pull request
Feb 10, 2024
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.