Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cmake logic for coloring support #795

Merged
merged 5 commits into from
Apr 30, 2023

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Apr 30, 2023

  • Use explicit cmake logic to enable coloring feature
  • Fix an issue number
  • Add doc
  • Small improve to OCCT code

@mwestphal mwestphal marked this pull request as ready for review April 30, 2023 08:46
@mwestphal mwestphal force-pushed the better_occt_coloring_cmake_logic branch from 0cad34f to d32073b Compare April 30, 2023 14:23
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #795 (b6284e4) into master (e4a4669) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #795      +/-   ##
==========================================
+ Coverage   96.32%   96.34%   +0.01%     
==========================================
  Files         115      115              
  Lines        5879     5878       -1     
==========================================
  Hits         5663     5663              
+ Misses        216      215       -1     
Impacted Files Coverage Δ
plugins/occt/module/vtkF3DOCCTReader.cxx 86.40% <0.00%> (+0.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mwestphal mwestphal requested a review from Meakk April 30, 2023 15:15
@mwestphal mwestphal merged commit 4992ca9 into f3d-app:master Apr 30, 2023
mwestphal added a commit that referenced this pull request Feb 10, 2024
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
…ake_logic

Better cmake logic for coloring support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants