Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with multi-config generators #799

Merged
merged 1 commit into from
May 8, 2023

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented May 5, 2023

Fix #790

@Meakk Meakk self-assigned this May 5, 2023
@mwestphal
Copy link
Contributor

I dont see where the fix is. you also need to remove this in the CI:

          - os: windows
            bundle_label: bundle #790

@Meakk
Copy link
Contributor Author

Meakk commented May 5, 2023

I set F3D_PLUGINS_PATH to lib_$<CONFIG> when running the tests, that's it.

@mwestphal
Copy link
Contributor

you still need to remove the bundle label

@Meakk Meakk force-pushed the fix-dynamic-plugins-test branch from dbef572 to 3b4185c Compare May 8, 2023 08:24
@Meakk Meakk merged commit 6e94404 into f3d-app:master May 8, 2023
@Meakk Meakk deleted the fix-dynamic-plugins-test branch May 8, 2023 17:46
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows + Dynamic plugins + multi generator break testing
2 participants