Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Assimp 16-bits and 32-bits textures #802

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

Meakk
Copy link
Contributor

@Meakk Meakk commented May 7, 2023

Fix #586

@Meakk Meakk self-assigned this May 7, 2023
@Meakk
Copy link
Contributor Author

Meakk commented May 7, 2023

@bisechen Can I add your dataset in the test database? Are you the original author?

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #802 (a94bc72) into master (cc27603) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #802   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         109      109           
  Lines        6171     6172    +1     
=======================================
+ Hits         5930     5931    +1     
  Misses        241      241           
Impacted Files Coverage Δ
plugins/assimp/module/vtkF3DAssimpImporter.cxx 89.54% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bisechen
Copy link

bisechen commented May 8, 2023

我可以在測試資料庫中添加您的數據集嗎?你是原作者嗎?

If you mean the PNG and FBX files with different bit depths, yes, that's a test I did offhand and you can use it as much as you like... ^^

testing/data/DATA_LICENSES.md Outdated Show resolved Hide resolved
@Meakk Meakk merged commit 06b2129 into f3d-app:master May 11, 2023
@Meakk Meakk deleted the fix-16bits branch May 11, 2023 12:01
@Meakk Meakk mentioned this pull request Jun 8, 2023
mwestphal pushed a commit that referenced this pull request Feb 10, 2024
mwestphalnew pushed a commit to mwestphalnew/f3d that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNG Mapping support
3 participants