-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add USD plugin #819
Add USD plugin #819
Conversation
119017b
to
2f248f4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 96.28% 96.42% +0.13%
==========================================
Files 120 124 +4
Lines 7167 7671 +504
==========================================
+ Hits 6901 7397 +496
- Misses 266 274 +8 ☔ View full report in Codecov by Sentry. |
839e864
to
b52695c
Compare
What is blocking this @Meakk ? |
Half of the reader code is not covered, we need to fix that :) |
@Meakk could we move this one forward with SSIM or PSNR image comparison ? |
d1b6ec8
to
8084239
Compare
@mwestphal please take a look. Coverage is good now and all comments have been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a https://f3d.app doc update
You are modifying libf3d public API! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only small changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small last comments then gtg
No description provided.