Add USD plugin #819
Merged
Add USD plugin #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
reviewed
May 20, 2023
mwestphal
reviewed
May 20, 2023
Closed
mwestphal
reviewed
Jun 1, 2023
mwestphal
reviewed
Jun 1, 2023
Meakk
force-pushed
the
usd
branch
3 times, most recently
from
119017b
to
2f248f4
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
==========================================
+ Coverage 96.28% 96.42% +0.13%
==========================================
Files 120 124 +4
Lines 7167 7671 +504
==========================================
+ Hits 6901 7397 +496
- Misses 266 274 +8 ☔ View full report in Codecov by Sentry. |
Meakk
force-pushed
the
usd
branch
4 times, most recently
from
839e864
to
b52695c
Compare
|
What is blocking this @Meakk ? |
mwestphal
reviewed
Sep 25, 2023
mwestphal
reviewed
Sep 25, 2023
mwestphal
reviewed
Sep 25, 2023
mwestphal
reviewed
Sep 25, 2023
mwestphal
reviewed
Sep 25, 2023
mwestphal
reviewed
Sep 25, 2023
|
Half of the reader code is not covered, we need to fix that :) |
mwestphal
reviewed
Oct 14, 2023
mwestphal
reviewed
Oct 14, 2023
|
@Meakk could we move this one forward with SSIM or PSNR image comparison ? |
Meakk
force-pushed
the
usd
branch
4 times, most recently
from
d1b6ec8
to
8084239
Compare
|
@mwestphal please take a look. Coverage is good now and all comments have been addressed. |
mwestphal
reviewed
Nov 15, 2023
mwestphal
reviewed
Nov 15, 2023
mwestphal
reviewed
Nov 15, 2023
mwestphal
reviewed
Nov 15, 2023
mwestphal
reviewed
Nov 15, 2023
mwestphal
reviewed
Nov 15, 2023
mwestphal
reviewed
Nov 15, 2023
mwestphal
reviewed
Nov 15, 2023
mwestphal
requested changes
Nov 15, 2023
Meakk
commented
Nov 20, 2023
|
You are modifying libf3d public API! |
mwestphal
reviewed
Nov 22, 2023
mwestphal
reviewed
Nov 22, 2023
mwestphal
reviewed
Nov 22, 2023
mwestphal
reviewed
Nov 22, 2023
mwestphal
requested changes
Nov 22, 2023
mwestphal
reviewed
Nov 22, 2023
mwestphal
approved these changes
Nov 22, 2023
mwestphal
pushed a commit
that referenced
this pull request
Feb 10, 2024
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.