Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the RPC method name to the netstats counters #178

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Add the RPC method name to the netstats counters #178

merged 1 commit into from
Jun 16, 2023

Conversation

jmacd
Copy link
Collaborator

@jmacd jmacd commented Jun 16, 2023 •
edited
Loading

Part of #119

Adds a method attribute to the counters in collector/gen/internal/netstats. This will help us know when downgrades are happening, for example.

@jmacd
Copy link
Collaborator Author

jmacd commented Jun 16, 2023

TESTED manually e.g.
image

@jmacd jmacd requested review from lquerel and kristinapathak June 16, 2023 20:48
lquerel
lquerel approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lquerel lquerel merged commit 8860838 into f5:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lquerel lquerel lquerel approved these changes

@kristinapathak kristinapathak Awaiting requested review from kristinapathak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmacd @lquerel