Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of the mouseClick function (add proportion and offset) #103

Merged
merged 3 commits into from
May 12, 2024

Conversation

53845714nF
Copy link
Contributor

Add new parameters (proportion and offset) to the mouseClick function. For the end User this will end in two new Functions mouseClickWithProportion and mouseClickWithOffset. It will be possible to click e.g. sliderarea at certain positions.

Can be used in Python, for example, as follows:

from xmlrpc.client import ServerProxy

session = ServerProxy('http://localhost:9000')
session.mouseClickWithProportion('mainWindow/sliderarea', 0.4, 0.5)

@53845714nF 53845714nF force-pushed the mouse_click_on_position branch from 6b24d6d to 34a7df6 Compare March 12, 2024 09:14
@53845714nF 53845714nF force-pushed the mouse_click_on_position branch 2 times, most recently from 9178e8a to de9f36c Compare March 19, 2024 12:46
@faaxm
Copy link
Owner

faaxm commented Mar 30, 2024

Thank you for your PRs @53845714nF ! I just want you to know that I am aware of them, but that I am super busy at the moment and it might take a while until I can have a proper look at them.

@53845714nF
Copy link
Contributor Author

No problem, I already suspected that.
I'm happy that it was noticed. I will take a look at the clang error.

Happy Easter holidays.

@53845714nF 53845714nF force-pushed the mouse_click_on_position branch from de9f36c to 54b5a9c Compare April 17, 2024 14:27
@53845714nF
Copy link
Contributor Author

I hope I solve the Clang Error.

@53845714nF 53845714nF changed the title Extension of the mouseClick function Extension of the mouseClick function (add proportion and offset) Apr 24, 2024
…l be possible to click e.g. sliderarea at certain positions.
@53845714nF 53845714nF force-pushed the mouse_click_on_position branch from 0440ff3 to 9eae928 Compare May 6, 2024 13:17
@53845714nF 53845714nF force-pushed the mouse_click_on_position branch from 9eae928 to 0569835 Compare May 6, 2024 13:20
Copy link
Owner

@faaxm faaxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍.
Could you merge in your pipeline fixes to stop the ci pipeline from failing? Once that runs through it can be merged :)

examples/GTestMouseClickPosition/main.cpp Outdated Show resolved Hide resolved
@faaxm
Copy link
Owner

faaxm commented May 12, 2024

just closing and reopening to have github rebase on latest master

@faaxm faaxm closed this May 12, 2024
@faaxm faaxm reopened this May 12, 2024
Co-authored-by: Falko Axmann <51922941+faaxm@users.noreply.github.com>
@53845714nF
Copy link
Contributor Author

I renamed it.

Copy link
Owner

@faaxm faaxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and thanks for putting in the effort 👍 Hope I soon find time for the remaining reviews... Doing this purely in my free time, so unfortunately spix doesn't always make it to the top of my priority list.

@faaxm faaxm merged commit 8358014 into faaxm:master May 12, 2024
22 checks passed
53845714nF added a commit to 53845714nF/spix that referenced this pull request May 23, 2024
…xm#103)

* Add new parameters (proportion and offset) to the mouse Click. It will be possible to click e.g. sliderarea at certain positions.
* Create a new GTest for Mouse Click Position
* Update examples/GTestMouseClickPosition/main.cpp

---------

Co-authored-by: Sebastian Feustel <sebastian.feustel@kdab.com>
Co-authored-by: Falko Axmann <51922941+faaxm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants