Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing CI #113

Merged
merged 2 commits into from
May 12, 2024
Merged

Fixing CI #113

merged 2 commits into from
May 12, 2024

Conversation

53845714nF
Copy link
Contributor

@53845714nF 53845714nF commented May 8, 2024 •
edited
Loading

Hello, I changed the CI, because I see some errors.

  1. MacOS 14 only supports Arm64 but Qt5 not, so I pin it to macOS 13 on Qt5.
  2. Bump Checkout Action from 3 to 4, because it uses an old Node Version.
  3. Adding an extra test case for macOS, because on macOS 14 with Qt6 the -platform minimal is not supported.

faaxm
faaxm requested changes May 11, 2024
View reviewed changes
Copy link
Owner

@faaxm faaxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool. Still haven't found time to look at all your other reviews but it's great to see the pipeline up and running again. Just found one minor thing, otherwise ok :-)

.github/workflows/run-examples.yml Outdated Show resolved Hide resolved
@faaxm faaxm merged commit acb4ff5 into faaxm:master May 12, 2024
22 checks passed
53845714nF added a commit to 53845714nF/spix that referenced this pull request May 23, 2024
@53845714nF @faaxm
Fixing CI (faaxm#113)
c474515 
* MacOS 14 only supports Arm64 but Qt5 not, so I pin it to macOS 13 on Qt5.
* Bump Checkout Action from 3 to 4, because it uses an old Node Version.
* Adding an extra test case for macOS, because on macOS 14 with Qt6 the -platform minimal is not supported.

---------

Co-authored-by: Sebastian Feustel <sebastian.feustel@kdab.com>
Co-authored-by: Falko Axmann <51922941+faaxm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faaxm faaxm faaxm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@53845714nF @faaxm