Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Extend original package with more connectivity util functions #21

Conversation

claired4l
Copy link

Adding following functions to communicate between react-native app and Android app:

  • void sendGenuineMessage(String messagePath, Callback replyCb, Callback errCb);
  • void getCapableAndReachableNodes(String capability, Callback replyCb, Callback errCb);
  • void getNonCapableAndReachableNodes(String capability, Callback replyCb, Callback errCb);
  • void openRemoteURI(String uri, String nodeId, Callback replyCb, Callback errCb);

See README for more details

@fabOnReact fabOnReact closed this Aug 6, 2024
@fabOnReact
Copy link
Owner

Sorry. I decided to not merge the PR, because I'm focusing our efforts on other priorities.

My plan is to follow as close as possible to the API react-native-watch-connectivity.

There is a list of issues and feature requests in the issue tracker.

I believe your APIs are a nice improvement, but they are best kept in a separate library.

We don't know how many users would benefit from these more advanced features, for this reason I'll prioritize other features for now but may come back to this PR and take inspiration in the future to add improvements to the library.

OpenSource is something we do in our free time. For this reason we need to be modest in our goal and avoid taking to much tech debt by adding a lot of complexity ti the library and maintenance.

So features that are not requested by the community may not get merged.

Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants