Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance and issues for nested variants #809

Merged
merged 2 commits into from
Sep 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions library/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ All notable changes to the library will be documented in this file.
## vX.X.X (Month DD, YYYY)

- Change `reference` property of all action base types to be less strict (issue #799)
- Change implementation of `variant` and `variantAsync` to improve performance and issues generation for nested variants with different discriminators (pull request #809)

## v0.40.0 (August 29, 2024)

Expand Down
4 changes: 2 additions & 2 deletions library/src/schemas/variant/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export interface VariantIssue extends BaseIssue<unknown> {
/**
* Variant option schema type.
*/
interface VariantOptionSchema<TKey extends string>
export interface VariantOptionSchema<TKey extends string>
extends BaseSchema<unknown, unknown, VariantIssue | BaseIssue<unknown>> {
readonly type: 'variant';
readonly reference: typeof variant;
Expand All @@ -62,7 +62,7 @@ interface VariantOptionSchema<TKey extends string>
/**
* Variant option schema async type.
*/
interface VariantOptionSchemaAsync<TKey extends string>
export interface VariantOptionSchemaAsync<TKey extends string>
extends BaseSchemaAsync<unknown, unknown, VariantIssue | BaseIssue<unknown>> {
readonly type: 'variant';
readonly reference: typeof variantAsync;
Expand Down

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion library/src/schemas/variant/utils/_discriminators/index.ts

This file was deleted.

1 change: 0 additions & 1 deletion library/src/schemas/variant/utils/index.ts

This file was deleted.

Loading