Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Farsi language to i18n #838

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Conversation

Hasan-Mir
Copy link
Contributor

No description provided.

@fabian-hiller
Copy link
Owner

Thank you for this PR! Do you know another native speaking developer that could review the translations for me?

@fabian-hiller fabian-hiller self-assigned this Sep 19, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Sep 19, 2024
@Hasan-Mir
Copy link
Contributor Author

@ImMo3n

@fabian-hiller fabian-hiller force-pushed the main branch 2 times, most recently from 7a97dd0 to b5f7f4d Compare October 3, 2024 17:45
@fabian-hiller
Copy link
Owner

@ImMo3n are you able to review it?

@ImMo3n
Copy link

ImMo3n commented Oct 16, 2024

@fabian-hiller I've looked at it, looks good.

@fabian-hiller
Copy link
Owner

Thank you! I plan to merge it soon!

Copy link

pkg-pr-new bot commented Oct 27, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/valibot@838

commit: 190c4d5

@fabian-hiller
Copy link
Owner

I have added translations for some new actions we have recently added. Can you check if my translations are correct?

packages/i18n/src/fa.ts Outdated Show resolved Hide resolved
packages/i18n/src/fa.ts Outdated Show resolved Hide resolved
@Hasan-Mir
Copy link
Contributor Author

Now it's ok.

@mammadataei
Copy link

Is there any plan to merge this PR? Is there anything I can help with?

@fabian-hiller
Copy link
Owner

Yes, I will probably merge it in the next days.

@fabian-hiller fabian-hiller merged commit 4d918a5 into fabian-hiller:main Nov 4, 2024
11 checks passed
@fabian-hiller
Copy link
Owner

v1.0.0-beta.1 of i18n is available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants