Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add czech lang #886

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Conversation

ivan-mihalic
Copy link
Contributor

Hello guys,
Here is a PR with czech language for i18n.
If you need someone who speaks native Czech, here is my friend @ferdinandurban

@fabian-hiller
Copy link
Owner

Thank you! Yeah, it would be great if he could review the PR for me! 🙏

@fabian-hiller fabian-hiller self-assigned this Oct 19, 2024
@fabian-hiller fabian-hiller added the enhancement New feature or request label Oct 19, 2024
packages/i18n/src/cs.ts Outdated Show resolved Hide resolved
packages/i18n/src/cs.ts Outdated Show resolved Hide resolved
@ivan-mihalic
Copy link
Contributor Author

Hi @fabian-hiller,
PR is ready for merge

@fabian-hiller
Copy link
Owner

Thank you! I will review and merge it soon.

@rnovacek
Copy link

I'm native Czech and it all looks good to me. Thanks for doing this.

@fabian-hiller
Copy link
Owner

I plan to review and merge it in the next days

Copy link

pkg-pr-new bot commented Nov 4, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/valibot@886

commit: 8395edf

@fabian-hiller fabian-hiller merged commit 7708468 into fabian-hiller:main Nov 4, 2024
11 checks passed
@fabian-hiller
Copy link
Owner

v1.0.0-beta.1 of i18n is available

email: (issue) => `Neplatný email: Obdrženo ${issue.received}`,
emoji: (issue) => `Neplatné emoji: Obdrženo ${issue.received}`,
empty: (issue) => `Neplatná délka: Očekáváno ${issue.expected}, ale obdrženo ${issue.received}`,
endsWith: (issue) => `Neplatný konec: Očekáváno ${issue.expected}, ale obdrženo ${issue.received}`,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "neplatný konec textu"?

notLength: (issue) => `Nedostatečná délka: Očekáváno ${issue.expected}, ale obdrženo ${issue.received}`,
notSize: (issue) => `Nedostatečná minimální velikost: Očekáváno ${issue.expected}, ale obdrženo ${issue.received}`,
notValue: (issue) => `Nedostatečná minimální hodnota: Očekáváno ${issue.expected}, ale obdrženo ${issue.received}`,
octal: (issue) => `Neplatné osmičkové číslo: Obdrženo ${issue.received}`,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to use "osmičkové" when "hexadecimální" is used? Wouldn't "oktalové" make more sense?

safeInteger: (issue) => `Neplatné bezpečné celé číslo: Obdrženo ${issue.received}`,
size: (issue) => `Neplatná velikost: Očekáváno ${issue.expected}, ale obdrženo ${issue.received}`,
someItem: (issue) => `Neplatná položka: Obdrženo ${issue.received}`,
startsWith: (issue) => `Neplatný začátek: Očekáváno ${issue.expected}, ale obdrženo ${issue.received}`,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "Neplatny zacatek textu"?

@jansedlon
Copy link

Hello guys, i just posted a few comments. It's just nitpicks but what do you think?

@fabian-hiller
Copy link
Owner

Thank you very much! I will wait for a response from native speakers. Feel free to create a new PR to improve the translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants