Skip to content

Commit

Permalink
Make a crio restart failure a warning instead of an error.
Browse files Browse the repository at this point in the history
This is a mismatch issue between new minikube versions and old ISO versions. It's
also unlikely to cause a real issue because it requires users to opt-into crio and
modify crio-specific settings to cause trouble.
  • Loading branch information
dlorenc committed Feb 15, 2018
1 parent ce6a727 commit 9fe9154
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/provision/buildroot.go
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,14 @@ CRIO_MINIKUBE_OPTIONS='{{ range .EngineOptions.InsecureRegistry }}--insecure-reg
if err := t.Execute(&crioOptsBuf, p); err != nil {
return err
}

if _, err = p.SSHCommand(fmt.Sprintf("sudo mkdir -p %s && printf %%s \"%s\" | sudo tee %s", path.Dir(crioOptsPath), crioOptsBuf.String(), crioOptsPath)); err != nil {
return err
}

// This is unlikely to cause issues unless the user has explicitly requested CRIO, so just log a warning.
if err := p.Service("crio", serviceaction.Restart); err != nil {
return err
log.Warn("Unable to restart crio service. Error: %s", err)
}

return nil
Expand Down

0 comments on commit 9fe9154

Please sign in to comment.