Remove old & confusing macros #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops. one sec |
|
@fabiangreffrath Do you want me to merge this now, or do you want me to work on it more? This could become the "general code cleanup" PR, or I could merge this one and do another one later on. There's an endless amount of cleanup to do, but I've tackled the most obvious things I've seen so far here. |
|
I'm fine if you merge this now. We don't need to clean out the entire code base in just one commit. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just general code cleanup. I'd also like to work on the DOPEFISH and SHAREWARE macros, but pruning those (while keeping the functionality) is a much more involved process.