Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cinematics off-by-one-pixel draw error #55

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

erysdren
Copy link
Collaborator

It's a little hard to notice, but in the opening cinematic with the ROTT logo, you can see some missing pixels at the bottom of the logo which is not there in the DOS version. It was just a slight mistake when translating the assembly to C. This commit fixes that.

Funny enough, ROTT:LE has this bug too.

rott/cin_main.c Outdated Show resolved Hide resolved
Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@erysdren erysdren merged commit cb6cfe7 into main Apr 12, 2024
4 checks passed
@erysdren erysdren deleted the cinematics_pixel_bug branch July 3, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants