Added some features #25
Conversation
Added extra keywords for new functions
Added new functions - setSyncDir(uint8_t dir) to adjust the interrupt direction FALLING, RISING, CHANGE - setSyncPullup(bool pullup) to activate internal pull-up resistor on zero-crossing detection - setGateTurnOffTime(uint16_t timeOff) to change the value of the gate turn off time
Added new functions - setSyncDir(uint8_t dir) to adjust the interrupt direction FALLING, RISING, CHANGE - setSyncPullup(bool pullup) to activate internal pull-up resistor on zero-crossing detection - setGateTurnOffTime(uint16_t timeOff) to change the value of the gate turn off time
Added new functions - setSyncDir(uint8_t dir) to adjust the interrupt direction FALLING, RISING, CHANGE - setSyncPullup(bool pullup) to activate internal pull-up resistor on zero-crossing detection - setGateTurnOffTime(uint16_t timeOff) to change the value of the gate turn off time
Added new functions - setSyncDir(uint8_t dir) to adjust the interrupt direction FALLING, RISING, CHANGE - setSyncPullup(bool pullup) to activate internal pull-up resistor on zero-crossing detection - setGateTurnOffTime(uint16_t timeOff) to change the value of the gate turn off time
Explain new functions
|
I am wondering why this couldn't be accepted. Are there any issues with a different edge direction of the interrupt or having an internal pull up resistor enabled? I am using some optocoupler that forces me to either mess with soldering pull down resistor or simply change to FALLING and enable pull up resistor to make it easier. Wondering if I could simply use this patch 🤔 |
I had the same optocoupler issue, that's why I did this update and gave it to them but they won't accept it It works flawlessly on my project; FALLING with internal pullups |
|
Thanks. I have already forked the repo to change the maximum dimmers, so might as well use this pull request. I am using Arduino Mega. Will see how it goes. |
|
Sorry, I missed this update. I gave it a quick glance and it seems fine. I will review it as soon as possible! |
This adds support for RP2040 based boards such as the Pico and the Pico W using arduino-pico. Note that this is distinctly different from the mbed-OS based platform which would have to be implemented separately. I have tested this on a Pico W.
Instead of hardcoding values, user can change them in definition/setup
The extra features of this request: