Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix django default appconfig deprecation warning #141

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

merwok
Copy link
Contributor

@merwok merwok commented Dec 3, 2021

fixes #140

@merwok
Copy link
Contributor Author

merwok commented Dec 3, 2021

Forgot that keeping forks in sync with github is not convenient — pulled and merged upstream.

I’ll rebase or you’ll squash merge!

@merwok merwok changed the title Fix django deprecation warnings Fix django default appconfig deprecation warning Dec 3, 2021
Copy link
Owner

@fabiocaccamo fabiocaccamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to remove this also for older django versions?

I would keep it if django.version < 4 to be 101% backward compatible.

@merwok
Copy link
Contributor Author

merwok commented Dec 3, 2021

I’m not fully sure, would need a test project with these versions. The worst case is that they would have to have 'admin_interface.apps.AdminInterfaceConfig' in INSTALLED_APPS instead of 'admin_interface' alone.


On the topic of supported versions, I also wanted to ask you how you would feel about reducing them!
Keeping 4 older python versions and 4 django versions (LTS or current):

diff --git a/tox.ini b/tox.ini
--- a/tox.ini
+++ b/tox.ini
@@ -1,35 +1,28 @@
 [tox]
 envlist =
-    py27-{dj17,dj18,dj19,dj110,dj111}-{sqlite,postgres},
-    py35-{dj18,dj19,dj110,dj111,dj20,dj21,dj22}-{sqlite,postgres},
-    py36-{dj18,dj19,dj110,dj111,dj20,dj21,dj22,dj30,dj31,dj32,djmaster}-{sqlite,postgres},
-    py37-{dj20,dj21,dj22,dj30,dj31,dj32,djmaster}-{sqlite,postgres},
-    py38-{dj22,dj30,dj31,dj32,djmaster}-{sqlite,postgres},
-    py39-{dj22,dj30,dj31,dj32,djmaster}-{sqlite,postgres},
+    py27-dj111-{sqlite,postgres},
+    py36-{dj22,dj31,dj32,djmaster}-{sqlite,postgres},
+    py37-{dj22,dj31,dj32,djmaster}-{sqlite,postgres},
+    py38-{dj22,dj31,dj32,djmaster}-{sqlite,postgres},
+    py39-{dj22,dj31,dj32,djmaster}-{sqlite,postgres},
+    py310-{dj22,dj31,dj32,djmaster}-{sqlite,postgres},

@fabiocaccamo
Copy link
Owner

I use this library on some very old projects and I like to update it to the latest version to use new features.

@fabiocaccamo fabiocaccamo merged commit 294f852 into fabiocaccamo:master Dec 6, 2021
@merwok merwok deleted the fix-deprecations branch December 6, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation notice for default_app_config
2 participants