Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add portuguese brazil language #149

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Conversation

leandromsd
Copy link
Contributor

No description provided.


#: admin.py:37
msgid "Logo"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the word is Logo in pt-br too, then the common practice would be to write it as the translated string.
It seems redundant but for other translators or tools that check translation files, it will be counted as translated instead of missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the sugestion. Done!

Copy link
Owner

@fabiocaccamo fabiocaccamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leandromsd could you replace the empty translations with the original text as suggested by @merwok please?

@leandromsd
Copy link
Contributor Author

@leandromsd could you replace the empty translations with the original text as suggested by @merwok please?

Of course Fabio. Done!

@fabiocaccamo fabiocaccamo merged commit 384a63f into fabiocaccamo:master Jan 20, 2022
@leandromsd
Copy link
Contributor Author

Fábio, how to create a new version of the library with these changes?

@merwok
Copy link
Contributor

merwok commented Jan 21, 2022

The next version to be released will include this. Usually a release quickly follows merged changes so probably in a few days!

@fabiocaccamo
Copy link
Owner

@leandromsd you can upgrade to 0.18.5 version.

@leandromsd
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants