Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align inline CSS #201

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Align inline CSS #201

merged 1 commit into from
Dec 5, 2022

Conversation

VaZark
Copy link
Contributor

@VaZark VaZark commented Nov 16, 2022

Related to #198

Copy link
Owner

@fabiocaccamo fabiocaccamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, but it totally ignores my latest comment on the issue.

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 95.55% // Head: 95.55% // No change to project coverage 👍

Coverage data is based on head (a42a144) compared to base (d4ea141).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files          36       36           
  Lines         405      405           
=======================================
  Hits          387      387           
  Misses         18       18           
Flag Coverage Δ
unittests 95.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VaZark
Copy link
Contributor Author

VaZark commented Nov 16, 2022

oops. Sorry, I completely forget about the comment. I just updated this since I was working on a different PR. I'll get back to this a bit later then

@fabiocaccamo fabiocaccamo added the enhancement New feature or request label Nov 29, 2022
@fabiocaccamo
Copy link
Owner

@VaZark I thought to this issue, the align top is the right alignment, but if modeltranslation widget is used on a field present in the inline, its languages tabs make the input field shift vertically creating a misalignment.

Maybe a solution could be to move the modeltranslation widget tabs to the bottom of the field, but I'm not sure of this.

Anyway... now I merge this PR and when I will work again on a multilanguage project I will come back on this to improve their integration.

@fabiocaccamo fabiocaccamo merged commit a75c161 into fabiocaccamo:master Dec 5, 2022
@VaZark VaZark deleted the inline-css branch December 9, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants