Include date hierarchy in quick removal links #218
Conversation
Codecov ReportBase: 94.64% // Head: 97.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 94.64% 97.58% +2.94%
==========================================
Files 36 36
Lines 392 414 +22
==========================================
+ Hits 371 404 +33
+ Misses 21 10 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
admin_interface/templates/admin_interface/date_hierarchy_removal_link.html
Outdated
Show resolved
Hide resolved
|
Tests are broken due to the use of |
|
Now that #176 is done, you can continue on this PR. |
|
When this will be completed I will publish a new release. |
|
@merwok is this PR ready or would you still like to make some changes? |
|
I want to add unit tests with mocks. Functional tests can come later. |
merwok
force-pushed
the
feature/date-hierarchy-removal-link
branch
from
63bd293 to
d95f945
Compare
it's not easy to instantiate ChangeList, and speccing from the class means that many attributes are not recognized
| @@ -13,7 +13,7 @@ python = | |||
| 3.11: py311 | |||
|
|
|||
| [testenv] | |||
| passenv = CI GITHUB_WORKFLOW | |||
| passenv = CI,GITHUB_WORKFLOW | |||
There was a problem hiding this comment.
I totally missed this change from tox 3 to 4, thank you very much!
BTW, tox is not used anymore in the CI, for this reason I have not noticed the breaking change.
There was a problem hiding this comment.
It’s used for the lint checks! (see preceding commit)
There was a problem hiding this comment.
tox is still used but these env variables are not used anymore.
There was a problem hiding this comment.
Ah I understand! tox still complained about the format (no spaces allowed)
|
For some unfathomable reason, github pre-fills squash merge commit description with all the commit messages, which makes very messy messages. I use the Refined Github browser extension that avoids that (and has many other goodies). |
|
Is that extension safe and from trusted developers? |
fixes #181