Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update padding & styles #114

Conversation

midhunadarvin
Copy link
Contributor

  • apply padding fixes
  • remove enableTrigger variable and directly use simpleTriggerReactiveForm.enabled
  • apply default styles of matInput

This is with reference to #113 . I couldn't directly update the feature branch so making a PR to the feature branch.

Notes :

  • The default styles of matInput have changed from the previous version ( https://material.angular.io/components/input/overview )
  • font family is unchanged ( font-family: Roboto,"Helvetica Neue" ) but some of the updated components have changes in font sizes, hence the difference in UI after updation.

- apply padding fixes
- remove `enableTrigger` variable and directly use `simpleTriggerReactiveForm.enabled`
-  apply default styles of matInput
Copy link

sonarqubecloud bot commented Feb 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@midhunadarvin
Copy link
Contributor Author

Hi @fabioformosa

There are a few issues from a maintenance perspective that i would like to point out.

@midhunadarvin
Copy link
Contributor Author

Hi @fabioformosa , Were you able to check the styles and padding on this PR ?

@fabioformosa
Copy link
Owner

Sure @midhunadarvin, it's in my todo list. I will review it tonight.

@fabioformosa fabioformosa merged commit c6f10e0 into fabioformosa:feature/#101_angular15_update Feb 8, 2024
2 checks passed
@midhunadarvin midhunadarvin deleted the feature/#101_angular15_update branch February 9, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants