Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets not working with IE10 - header casing. #183

Closed
ReimerA opened this issue Nov 4, 2016 · 1 comment
Closed

WebSockets not working with IE10 - header casing. #183

ReimerA opened this issue Nov 4, 2016 · 1 comment
Labels
Milestone

Comments

@ReimerA
Copy link

ReimerA commented Nov 4, 2016

After some research into a problem with websockets through fabio when using IE10, I have discovered that IE10 sends the following header:

Upgrade: Websocket

It seems fabio i not treating this header value wrong because of the casing.

I have a SignalR application behind fabio, and I get an error (400), and SignalR falls back on longpolling. However if I edit the request for initiating the websocket connection in fiddler, and change the header to the below it seems to work (the request gets a 101 back not a 400) (notice the casing).

Upgrade: websocket

@magiconair magiconair added the bug label Nov 4, 2016
magiconair added a commit that referenced this issue Nov 4, 2016
The value of the Upgrade header can either be
"websocket" or "Websocket".
@magiconair
Copy link
Contributor

Merged the fix to master. You'll have to build a version yourself for now. I'll release a fix version in a couple of days. I'll close this one now. Feel free to re-open or comment if this does not solve your issue.

@magiconair magiconair added this to the 1.3.5 milestone Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants