Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing 'cs' in map #189

Closed
raben2 opened this issue Nov 17, 2016 · 4 comments
Closed

missing 'cs' in map #189

raben2 opened this issue Nov 17, 2016 · 4 comments
Labels
bug
Milestone
1.3.5

Comments

@raben2
Copy link

raben2 commented Nov 17, 2016

Hi,

i finally got to update my fabio installation to 1.3.4 and now i am trying to use the path based certificate store.

I need to setup a secondary cs for client cert usage because i only use it with several integration systems.

proxy.cs = cs=main;type=path;cert=/etc/nginx/certs;refresh=3s, \
                 cs=client;type=path;cert=/etc/nginx/cs1;clientca=/etc/nginx/cs1/client;refresh=3s

When i now start up fabio i get the following error:

[FATAL] 1.3.4. missing 'cs' in map[ cs:client type:path cert:/etc/nginx/cs1 clientca:/etc/nginx/comonea/cs1 refresh:3s]
BTW. Your Wiki has an error within the examples

 # path based certificate source
 proxy.cs = cs=some-name;type=path;path=path/to/certs

should be:
proxy.cs = cs=some-name;type=path;cert=path/to/certs

Thanks in advance
Georg
@magiconair
Copy link
Contributor

Looking

@magiconair
Copy link
Contributor

Fixed wiki.

magiconair added a commit that referenced this issue Nov 28, 2016
@magiconair
Issue #189: missing 'cs' in map
f231c67 
Arguments which are configured as KV slices do not have
spaces trimmed off the key values. This breaks parsing
values like 'k1=v1; k2=v2' as 'k1=v1' and 'k2=v2'.
@magiconair
Copy link
Contributor

The parser for the key=val;key=val lists did not trim spaces from the keys. Removing the space in the argument works around the issue. This patch fixes that.

@magiconair magiconair added the bug label Nov 28, 2016
@magiconair magiconair modified the milestones: 1.3.3, 1.3.5 Nov 28, 2016
@raben2
Copy link
Author

raben2 commented Nov 30, 2016

thank you, it purrs like a kitten now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3.5
Development

No branches or pull requests
2 participants
@magiconair @raben2