Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include services with check ids other than 'service:*' #29

Closed
magiconair opened this issue Dec 14, 2015 · 1 comment
Closed

Include services with check ids other than 'service:*' #29

magiconair opened this issue Dec 14, 2015 · 1 comment
Milestone

Comments

@magiconair
Copy link
Contributor

When you register a health check together with a service in consul the health check gets an id of service:name-node-port. Fabio currently relies on the service: prefix to tell service checks from node and maintenance checks but this is not reliable since you can register health checks for services separately and there you can specify your own check id.

If your service does not show up in fabio although you have a passing health check verify that the check id starts with service: until this is fixed. Run curl localhost:8500/v1/health/state/any to see all health checks.

@magiconair magiconair changed the title Fabio ignores services which check ids other than 'service:*' Include services with check ids other than 'service:*' Dec 14, 2015
@magiconair magiconair added this to the 1.0.8 milestone Dec 14, 2015
@magiconair
Copy link
Contributor Author

Patch fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant