Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.5.0 config compatibility problem #305

Closed
pipozzz opened this issue Jun 13, 2017 · 10 comments
Closed

1.5.0 config compatibility problem #305

pipozzz opened this issue Jun 13, 2017 · 10 comments
Labels
bug
Milestone
1.5.2

Comments

@pipozzz
Copy link

pipozzz commented Jun 13, 2017 •
edited by magiconair
Loading

Hello,

I have a problem with fabio upgrade to the latest 1.5.0

this is my config:

proxy.cs = cs=consul-cs;type=consul;cert=http://localhost:8500/v1/kv/ssl?token=token
proxy.addr = :443;cs=consul-cs,:80,:2375;proto=tcp+sni

I see in output just this:
2017/06/13 13:27:03 [FATAL] 1.5.0. =

Where could be a problem?

Thank you.
@magiconair
Copy link
Contributor

I've refactored the code for parsing the proxy.addr values. Let me have a look.

@magiconair
Copy link
Contributor

The problem is the second = in the proxy.cs line. This is a bug in the parseKVSlice code. I'll fix it.

magiconair added a commit that referenced this issue Jun 13, 2017
@magiconair
Issue #305: allow kv values with equal signs
2baaef4 
This patch fixes the parsing of "a=b=c" into "a": "b=c"

Fixes #305
@magiconair
Copy link
Contributor

I've pushed a fix in the issue-305 branch. Could you check whether this fixes the problem for you?

@pipozzz
Copy link
Author

pipozzz commented Jun 13, 2017

Great, I checked that, everything works properly, thanks

@magiconair magiconair added the bug label Jun 17, 2017
@pipozzz
Copy link
Author

pipozzz commented Jul 3, 2017

When do you plan to merge that fix to new release?
Thanks

@magiconair
Copy link
Contributor

Today or tomorrow. Is that soon enough?

@pipozzz
Copy link
Author

pipozzz commented Jul 3, 2017

Great !!, I'm just asking

Thanks

@pipozzz
Copy link
Author

pipozzz commented Jul 7, 2017

Did you forget on this issue in new release?
I would like to use latest version of fabio, if possible.

@magiconair
Copy link
Contributor

Damn. Yes. I'll push a 1.5.2 soon. Might be early next week though.

@pipozzz
Copy link
Author

pipozzz commented Jul 7, 2017

Thanks, it would help me a lot 👍

@magiconair magiconair added this to the 1.5.2 milestone Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.5.2
Development

No branches or pull requests
2 participants
@magiconair @pipozzz