-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics for TCP and TCP+SNI proxy #306
Comments
It is correct that the TCP proxy does not collect metrics at the moment since most of the metrics I'm collecting only make sense in for HTTP. Which metrics would you like to see? |
out of the top of my head i would expect to see
|
number of connections and tx & rx would be good. |
This patch adds metrics for the TCP and TCP+SNI proxy. Fixes #306
This patch adds metrics for the TCP and TCP+SNI proxy. Fixes #306
This patch adds metrics for the TCP and TCP+SNI proxy. Fixes #306
I've added the metrics but the naming needs some more work since I'd like to add the protocol to the metrics name. Right now you get:
I've defined
Also, in order to support #211 I finally need to address the metrics naming problem ... Could you please have a look whether that works for you? |
@InformatiQ and @csawyerYumaed are you still interested in this? |
Hi sorry, I somehow missed this back when. This looks fine for me. We can group by server.1234.* to count total traffic in/out. Thanks! |
No description provided.
The text was updated successfully, but these errors were encountered: