Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for TCP and TCP+SNI proxy #306

Closed
InformatiQ opened this issue Jun 16, 2017 · 6 comments
Closed

Add metrics for TCP and TCP+SNI proxy #306

InformatiQ opened this issue Jun 16, 2017 · 6 comments
Milestone

Comments

@InformatiQ
Copy link

No description provided.

@magiconair magiconair changed the title metrics all setto zero when proxying TCP metrics all set to zero when proxying TCP Jun 16, 2017
@magiconair
Copy link
Contributor

It is correct that the TCP proxy does not collect metrics at the moment since most of the metrics I'm collecting only make sense in for HTTP. Which metrics would you like to see?

@InformatiQ
Copy link
Author

out of the top of my head i would expect to see

  • number of connections
  • tx and rx stats per service

@csawyerYumaed
Copy link

csawyerYumaed commented Jun 29, 2017

number of connections and tx & rx would be good.

magiconair added a commit that referenced this issue Jun 29, 2017
This patch adds metrics for the TCP and TCP+SNI proxy.

Fixes #306
magiconair added a commit that referenced this issue Jun 29, 2017
This patch adds metrics for the TCP and TCP+SNI proxy.

Fixes #306
magiconair added a commit that referenced this issue Jun 29, 2017
This patch adds metrics for the TCP and TCP+SNI proxy.

Fixes #306
@magiconair
Copy link
Contributor

I've added the metrics but the naming needs some more work since I'd like to add the protocol to the metrics name. Right now you get:

counter tcp.conn
counter tcp.connfail
counter tcp.noroute
counter tcp_sni.conn
counter tcp_sni.connfail
counter tcp_sni.noroute
counter server._1234._.127_0_0_1_5000.rx
counter server._1234._.127_0_0_1_5000.tx

I've defined rx and tx as follows:

// rx measures the traffic to the upstream server (in <- out)
// tx measures the traffic from the upstream server (out <- in)

Also, in order to support #211 I finally need to address the metrics naming problem ...

Could you please have a look whether that works for you?

@magiconair
Copy link
Contributor

@InformatiQ and @csawyerYumaed are you still interested in this?

@csawyerYumaed
Copy link

Hi sorry, I somehow missed this back when. This looks fine for me. We can group by server.1234.* to count total traffic in/out. Thanks!

@magiconair magiconair changed the title metrics all set to zero when proxying TCP Add metrics for TCP and TCP+SNI proxy Aug 11, 2017
@magiconair magiconair added this to the 1.6.0 milestone Oct 10, 2017
@magiconair magiconair modified the milestones: 1.6, 1.5.3 Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants