Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI broken where no internet access. #502

Closed
yakcamnevets opened this issue May 29, 2018 · 2 comments · Fixed by #643
Closed

UI broken where no internet access. #502

yakcamnevets opened this issue May 29, 2018 · 2 comments · Fixed by #643

Comments

@yakcamnevets
Copy link

Hello, the UI is broken on computers where to there no internet access. Could the jquery, materialize, etc. resources be included in fabio instead of loaded from the internet? Thanks.

Loading failed for the <script> with source “https://code.jquery.com/jquery-3.3.1.min.js”.
routes:7
Loading failed for the <script> with source “https://cdnjs.cloudflare.com/ajax/libs/materialize/0.100.2/js/materialize.min.js”.
routes:10
ReferenceError: $ is not defined[Learn More]
@ymmijgno
Copy link

2nd that. any work around or the intention to fix this?

@magiconair
Copy link
Contributor

Feel free to send a PR. This shouldn't be hard to fix.

@pschultz pschultz mentioned this issue Apr 16, 2019
Closed
pschultz added a commit that referenced this issue Apr 16, 2019
@pschultz
ui: Bundle assets
53c6952 
Use statik to bundle UI assets, so the UI works without an Internet
connection and with Browser privacy plugins.

Closes #502.

Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
@pschultz pschultz mentioned this issue Apr 16, 2019
Merged
aaronhurt pushed a commit that referenced this issue May 6, 2019
@pschultz
Bundle UI assets (#643)
86dde1c 
* vendor: add github.com/rakyll/statik

The updates to seemingly unrelated package checksums in go.mod are
likely caused by vendoring with a Go version newer than 1.11.3
(see http://golang.org/issue/29278).

Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>

* ui: Bundle assets

Use statik to bundle UI assets, so the UI works without an Internet
connection and with Browser privacy plugins.

Closes #502.

Signed-off-by: Peter Schultz <peter.schultz@classmarkets.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bundle UI assets fabiolb/fabio
3 participants
@magiconair @yakcamnevets @ymmijgno