Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted routes hide visible routes #57

Closed
magiconair opened this issue Feb 19, 2016 · 3 comments
Closed

Deleted routes hide visible routes #57

magiconair opened this issue Feb 19, 2016 · 3 comments
Labels
Milestone

Comments

@magiconair
Copy link
Contributor

All versions of fabio have the following bug:

If you delete all routes of a service with the route del service manual override then paths registered by this service are still considered for routing.

Given this routing table

route add serviceA /foo http://127.0.0.1:5000/
route add serviceB /foo/bar http://127.0.0.1:5001/
route del serviceB

the log will print the correct routing table

route add serviceA /foo http://127.0.0.1:5000/

but internally there is still a route for /foo/bar with no targets which is evaluated during lookup. Therefore, a request for /foo/bar will not be routed to serviceA but to nowhere since the dangling route has no targets.

The current workaround is to add a manual override for the specific route to serviceA, e.g.

route add serviceA /foo/bar http://127.0.0.1:5000/
@magiconair magiconair added the bug label Feb 19, 2016
@magiconair
Copy link
Contributor Author

Thanks for @ilya-pi for finding it.

@magiconair
Copy link
Contributor Author

Hmm, the fix for this bug fundamentally conflicts with issue #52 since there the deleted routes are only marked but not removed. I may have to rethink that

@magiconair
Copy link
Contributor Author

I'll roll this fix first and then refactor for issue #52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant