Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabio does not respect registry_consul_register_ip from ENV #77

Closed
sielaq opened this issue Apr 7, 2016 · 1 comment
Closed

fabio does not respect registry_consul_register_ip from ENV #77

sielaq opened this issue Apr 7, 2016 · 1 comment
Milestone

Comments

@sielaq
Copy link
Contributor

sielaq commented Apr 7, 2016

Starting fabio with different UI port like

ui_addr=:81 registry_consul_register_ip=:81 registry_consul_register_name=foo fabio

still register to consul with 9998, is UI port is hardcoded ?

2016/04/07 20:13:27 [INFO] Version 1.1.1 starting
2016/04/07 20:13:27 [INFO] Runtime config
{
    "Proxy": {
        "Strategy": "rnd",
        "MaxConn": 10000,
        "ShutdownWait": 0,
        "DialTimeout": 30000000000,
        "ResponseHeaderTimeout": 0,
        "KeepAliveTimeout": 0,
        "LocalIP": "10.0.2.15",
        "ClientIPHeader": "",
        "TLSHeader": "",
        "TLSHeaderValue": ""
    },
    "Registry": {
        "Backend": "consul",
        "Static": {
            "Routes": ""
        },
        "File": {
            "Path": ""
        },
        "Consul": {
            "Addr": "localhost:8500",
            "Token": "",
            "KVPath": "/fabio/config",
            "TagPrefix": "urlprefix-",
            "ServiceAddr": ":9998",
            "ServiceName": "foo",
            "CheckInterval": 1000000000,
            "CheckTimeout": 3000000000
        }
    },
    "Listen": [
        {
            "Addr": ":9999",
            "KeyFile": "",
            "CertFile": "",
            "ClientAuthFile": "",
            "TLS": false,
            "ReadTimeout": 0,
            "WriteTimeout": 0
        }
    ],
    "Metrics": [
        {
            "Target": "",
            "Prefix": "default",
            "Interval": 30000000000,
            "Addr": ""
        }
    ],
    "UI": {
        "Addr": ":81",
        "Color": "light-green",
        "Title": ""
    },
    "Runtime": {
        "GOGC": 800,
        "GOMAXPROCS": 1
    }
}
2016/04/07 20:13:27 [INFO] Setting GOGC=800
2016/04/07 20:13:27 [INFO] Using GOMAXPROCS=4 from env
2016/04/07 20:13:27 [INFO] Metrics disabled
2016/04/07 20:13:27 [INFO] consul: Connecting to "localhost:8500" in datacenter "unknown"
2016/04/07 20:13:27 [INFO] consul: Registered fabio as "foo-standalone-9998" with address ":9998" and health check to "http://[10.0.2.15]:9998/health"
2016/04/07 20:13:27 [INFO] Admin server listening on ":81"
2016/04/07 20:13:27 [INFO] Using routing strategy "rnd"
2016/04/07 20:13:27 [INFO] HTTP proxy listening on :9999
2016/04/07 20:13:27 [INFO] consul: Using dynamic routes
2016/04/07 20:13:27 [INFO] consul: Using tag prefix "urlprefix-"
2016/04/07 20:13:27 [INFO] consul: Watching KV path "/fabio/config"
2016/04/07 20:13:27 [INFO] consul: Manual config changed to #1
``
@sielaq
Copy link
Contributor Author

sielaq commented Apr 7, 2016

ok this is just documentation issue
in
https://raw.githubusercontent.com/eBay/fabio/master/fabio.properties

# registry.consul.register.addr configures the address for the service registration.
#
# Fabio registers itself in consul with this host:port address.
# It must point to the UI/API endpoint configured by ui.addr and defaults to its
# value.
#
# The default is
#
-# registry.consul.register.ip = :9998
+# registry.consul.register.addr = :9998

sielaq added a commit to sielaq/fabio that referenced this issue Apr 7, 2016
@magiconair magiconair added this to the 1.1.2 milestone Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants