Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tags for fabio service registration #96

Closed
robholland opened this issue May 5, 2016 · 6 comments
Closed

Allow tags for fabio service registration #96

robholland opened this issue May 5, 2016 · 6 comments
Labels
enhancement
Milestone
1.1.3

Comments

@robholland
Copy link

Please add a way to configure tags that fabio will set on the service it registers. This will allow us to connect to the admin interface of a specific fabio instance when we have more than one fabio instance in a balancer configuration.
magiconair added a commit that referenced this issue May 5, 2016
@magiconair
Issue #96: Allow tags for fabio service registration
9da69a2
@magiconair
Copy link
Contributor

Like this? Could you test it and let me know whether that works for you?

@robholland
Copy link
Author

Yeah, I'll give that a test, cheers!

magiconair added a commit that referenced this issue May 5, 2016
@magiconair
Issue #96: Allow tags for fabio service registration
d056f23
@magiconair
Copy link
Contributor

Forgot logging.

@robholland
Copy link
Author

I didn't check the log output, but the tags are set properly :)

@magiconair
Copy link
Contributor

ok, then I'll merge that one as well.

@magiconair magiconair changed the title Configuring consul tags for the service fabio registers Allow tags for fabio service registration May 5, 2016
magiconair added a commit that referenced this issue May 5, 2016
@magiconair
Issue #96: Allow tags for fabio service registration
6c8d1ec
@magiconair
Copy link
Contributor

merged.

@magiconair magiconair added this to the 1.1.3 milestone May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.1.3
Development

No branches or pull requests
2 participants
@robholland @magiconair