Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #4

Closed
wants to merge 1 commit into from
Closed

Add Dockerfile #4

wants to merge 1 commit into from

Conversation

jeinwag
Copy link
Contributor

@jeinwag jeinwag commented Oct 23, 2015

Since fabio is something that I'd probably like to see running in a container, I've added a Dockerfile.
Yields a small image (about 16 MB).
Inspired by Jeff Lindsay's Dockerfile for registrator.

@magiconair
Copy link
Contributor

I'll try that myself first before I merge.

@magiconair
Copy link
Contributor

I've produced an official image from a scratch container also with the integrated ca-certificates.crt file to provide proper SSL support but I still need to test that with a valid cert. Could you try whether this image works for you since I'm not using Docker? If it is OK then I'll push my change.

docker run -d -p 9999:9999 -p 9998:9998 -v $PWD/fabio.properties:/fabio.properties magiconair/fabio

@jeinwag
Copy link
Contributor Author

jeinwag commented Oct 26, 2015

Thanks, looks good to me!

@magiconair
Copy link
Contributor

I've moved the config file from /fabio.properties to /etc/fabio/fabio.properties so that you can store the configuration and one or more SSL certs in a single directory and just mount that instead of the individual files. I've updated the magiconair/fabio:latest and magiconair/fabio:1.0.3 docker images accordingly.

Docker support is now official and I'm closing this pull request (not merging)

@magiconair magiconair closed this Oct 27, 2015
kmfischer3 added a commit to galen0624/fabio that referenced this pull request Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants