Added new case insensitive matcher #553
Conversation
|
|
route/matcher.go
Outdated
| @@ -12,6 +12,7 @@ type matcher func(uri string, r *Route) bool | |||
| var Matcher = map[string]matcher{ | |||
| "prefix": prefixMatcher, | |||
| "glob": globMatcher, | |||
| "noCase": noCaseMatcher, | |||
There was a problem hiding this comment.
I feel like this might be a terrible name, but it's the best I could come up with this evening. I'm open to suggestions
|
I've never done GoLang before, but this seemed pretty straight forward based on the other examples. Let me know if I missed anything. |
route/matcher.go
Outdated
| @@ -12,6 +12,7 @@ type matcher func(uri string, r *Route) bool | |||
| var Matcher = map[string]matcher{ | |||
| "prefix": prefixMatcher, | |||
| "glob": globMatcher, | |||
| "noCase": noCaseMatcher, | |||
route/matcher.go
Outdated
| func noCaseMatcher(uri string, r *Route) bool { | ||
| lowerURI := strings.ToLower(uri) | ||
| lowerPath := strings.ToLower(r.Path) | ||
| return strings.HasPrefix(lowerURI, lowerPath) |
There was a problem hiding this comment.
After looking at this again, I think this should be a case insensitive prefix match. Originally I was using EqualFold. Thoughts?
There was a problem hiding this comment.
// todo(fs): if this turns out to be a performance issue we should cache
// todo(fs): strings.ToLower(r.Path) in r.PathLower
return strings.HasPrefix(strings.ToLower(uri), strings.ToLower(r.Path))
config/load.go
Outdated
| @@ -247,7 +247,7 @@ func load(cmdline, environ, envprefix []string, props *properties.Properties) (c | |||
| return nil, fmt.Errorf("invalid proxy.strategy: %s", cfg.Proxy.Strategy) | |||
| } | |||
|
|
|||
| if cfg.Proxy.Matcher != "prefix" && cfg.Proxy.Matcher != "glob" && cfg.Proxy.Matcher != "noCase" { | |||
| if cfg.Proxy.Matcher != "prefix" && cfg.Proxy.Matcher != "glob" && cfg.Proxy.Matcher != "nocase" { | |||
There was a problem hiding this comment.
With respect to the case-insensitive prefix matching I think iprefix is a better name.
fabio.properties
Outdated
| @@ -297,6 +297,7 @@ | |||
| # | |||
| # prefix: prefix matching | |||
| # glob: glob matching | |||
| # nocase: matches using a case insensitive test | |||
There was a problem hiding this comment.
# iprefix: case-insensitive prefix matching
|
I believe I've addressed all of your comments. I just wanted to make sure there wasn't something I missed that you're still waiting on. Are there any other changes you'd like to see on this? |
|
Any update on this? We really need this in order to migrate to fabio |
|
Thank you and sorry that it took so long! |
This adds the ability to have case insensitive matching for routes. This is important for projects that need to migrate from other load balancers that are case insensitive.