Added compiled glob matching using LRU cache #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galen0624
changed the title
|
#554 The use of sync.Map increased the performance from 3500 TPS to 6500 TPS. |
|
#554 Updated glob_cache to support all types that implement the glob.Glob Interfaces. Make test now passes all checks. |
|
#554 Updated to remove type switch and assert type to glob.Glob interface. |
|
This looks OK. If you rebase this then we can merge this as well. I assume you're using that in production as well? |
|
We are not using this in prod. We don't use GLOB matching. That being said we have tested it. -- #554 (comment) I will rebase line and PR. |
|
rebased this PR. |
|
Closing and recreating with new PR #615 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#554 Review for CPU usage of Mutex.