update github.com/hashicorp/consul/api to v1.4.0 #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update the go modules with the proper semantic versioning tag and ensure it matches the vendor in sources? See here for more information with working with the new go modules system: https://github.com/golang/go/wiki/Modules |
…ub.com/hashicorp/consul/api
|
My first time using go modules, sorry |
|
@andyroyle this is also needed for #517 and #566 ... do you have the time to update it to use v1.4.0 as a module or would you like me to close it? |
aaronhurt
pushed a commit
to myENA/fabio
that referenced
this pull request
Nov 15, 2018
magiconair
changed the title
|
LGTM |
|
Cheers! |
|
@andyroyle I hope I didn't step on your toes. There were a few other PRs waiting on an update of the library. Thank you very much for the contribution ... and the motivation to get it updated :) |
|
Not at all, I just wanted the updated consul client 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.